Skip to content

Expose rounding routines: fix max_ellipsoid validation and documentation#43

Open
shauryasingh310-ops wants to merge 1 commit into
GeomScale:developfrom
shauryasingh310-ops:fix/expose-rounding-routines
Open

Expose rounding routines: fix max_ellipsoid validation and documentation#43
shauryasingh310-ops wants to merge 1 commit into
GeomScale:developfrom
shauryasingh310-ops:fix/expose-rounding-routines

Conversation

@shauryasingh310-ops
Copy link
Copy Markdown

Expose rounding routines: fix max_ellipsoid validation and documentation

Resolves #30 - Expose new rounding routines

Changes:

  1. Fix missing throw statement (src/rounding.cpp)

    • Add throw keyword to max_ellipsoid validation error
    • Ensures proper error handling when max_ellipsoid is used on V-polytopes/Zonotopes
  2. Clarify rounding method restrictions (R/round_polytope.R)

    • Document that max_ellipsoid only works with H-polytopes
    • Fix typos: "mimimmum" → "minimum", "mee" → "isotropy"
    • Update default method documentation

Methods supported:

  • min_ellipsoid: Works on all polytope types (H, V, Zonotope)
  • max_ellipsoid: H-polytopes only (inscribed ellipsoid)
  • isotropy: Works on all polytope types (SVD-based)

Result: All rounding routines now properly exposed and documented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose new rounding routines

1 participant