I Fixed copy_array dangling pointer bug in VPolytope#473
Open
DhanushShetty18 wants to merge 1 commit into
Open
I Fixed copy_array dangling pointer bug in VPolytope#473DhanushShetty18 wants to merge 1 commit into
DhanushShetty18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello , Myself Dhanush (Artificial Intelligence and Data Science Student)
While exploring the VPolytope implementation for GSoC 2026,
I noticed a TODO comment on line 30 about raw pointer usage.
then found that copy_array() takes
T* resultby value. The
result = tarrayinside the functiononly updates a local copy , the caller's pointer remains pointing
to freed memory (dangling pointer), and the newly allocated
memory is leaked.
Fix:
1.Changed return type from void to T* and return the newly allocated array..
2.Updated all 6 call sites in operator= to capture the returned pointer.
THEN,
Added a test in volume_cb_vpolytope.cpp that copies a
VPolytope and verifies the copy is usable after assignment and
tested with full_dimensional_polytope_test:
9 tests, 38 assertions, 0 failures.