Skip to content

feat(notifications): groups #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 18, 2025
Merged

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Nov 6, 2024

fix: #1191 #176

Very far from done.

@GeopJr
Copy link
Owner Author

GeopJr commented May 16, 2025

it's getting shape but I still need:

  1. do actual widgets, this 'fit group notifications in normal ones' is pretty bad
  2. organize the version keeping mechs better
  3. make sure the upgrade is seamless

@GeopJr GeopJr marked this pull request as ready for review May 17, 2025 22:28
@GeopJr
Copy link
Owner Author

GeopJr commented May 17, 2025

I quite hate it because it's messy when you want to support both v1 and v2, but whatever at this point...

should be done
Screenshot From 2025-05-18 00-35-38

@GeopJr
Copy link
Owner Author

GeopJr commented May 18, 2025

Some other stuff:

  • I never noticed it before but it seems that the notifications websocket never emits updates and deletions. We need to deal with them however for privacy reasons (aka if someone mentions u and updates or deletes the post, youll still have it there...). To solve that we are forwarding events from the home websocket
  • to_widget was marked as throwing an Oopsie. This was because it's an abstract method and we needed the empty one to always throw. But that's a programmer error if they haven't implemented it. The right solution is to assert instead, so we don't have to try and catch everywhere especially since we know it will never error.

@GeopJr GeopJr merged commit bc44359 into main May 18, 2025
5 checks passed
@GeopJr GeopJr deleted the feat/notifications/grouped_notifications branch May 18, 2025 13:01
@GeopJr GeopJr linked an issue May 18, 2025 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Support Mastodon's native grouped notifications. [Request]: compact / concise notifications
1 participant