feat: port to adaptive dialogs

[oscfdezdz]

All remaining dialogs, except for the composer (#623), should be covered by this PR.

Fixes #777

[GeopJr]

Thank you so much Óscar! 🙇

Don't worry about the CI, I'll deal with it!

[oscfdezdz]

Something is wrong, Esc key to close dialogs doesn't work and it should by default with AdwDialog.

[GeopJr]

(I haven't looked into this PR yet)

Does it happen on all dialogs or some? In some cases we handle it https://github.com/search?q=repo%3AGeopJr%2FTuba+add_binding_action+%28Gdk.Key.Escape&type=code. Anything that is not set to window.close should probably have its AdwDialog's can-close set to false

[oscfdezdz]

All, even with Report dialog that has report.back binding and not window.close. It seems like the main window is capturing the shortcut instead, if the active AdwNavigationPage has a back button it would go back when the dialog is open

From what I understand from the migration guide and code, we should not have to explicitly specify it https://gitlab.gnome.org/GNOME/libadwaita/-/blob/main/src/adw-dialog.c?ref_type=heads#L1188-L1189

[GeopJr]

Yeah looks like the global esc accel is causing it

Tuba/src/Application.vala

Line 251 in 354cde1

set_accels_for_action ("app.back", {"<Alt>BackSpace", "<Alt>Left", "Escape", "<Alt>KP_Left", "Pointer_DfltBtnPrev"});

Removing it ("Escape") seems to fix it, though it's still needed :/ Maybe we can check if any dialogs are visible and handle it?

cc: @alice-mkh

[alice-mkh]

Why do you even need that action? Navigation view already has an action for going back AND handles shortcuts

[GeopJr]

The mediaviewer is an overlay and app.back dismisses it if it's open. I removed the ones navigationview handles and made the mediaviewer dismiss itself on its keypress event instead

[alice-mkh]

Can't you use navigation view for media viewer?

[GeopJr]

It used to be a stack but changed to an overlay when the scalerevealer was added for the transitions and drag effect

Screencast.from.2024-02-27.13-12-21.webm

[alice-mkh]

I see. Well either way, the way it handles shortcuts is very broken and things would work if you redo it the correct way, using add_binding() etc (on the widget itself, not on the window)

(and make sure you stop handling as needed)

[alice-mkh]

I do want to support transitions like in nav view in future, but yeah, right now it's not possible.