-
Couldn't load subscription status.
- Fork 11
Added information on resampling algorithms for overviews #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GL-S
wants to merge
12
commits into
main
Choose a base branch
from
add-resampling-algo-mosaics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e708aab
added-resampling-algo-LC-mosaics
GL-S b2c50d1
added-details-overview-algos
GL-S c7908f0
small-formatting
GL-S c7bfa0e
grammar
GL-S 0561e04
note-format
GL-S 75ea35c
fixed-animation-out-dropdown
GL-S 7a9ddc9
Update _access.md
GL-S 6bba2dd
Update _access.md
GL-S e591123
Update _access.md
GL-S 3ddbc61
edit-after-robbi-suggestion
GL-S aacb877
removed-unsure-detail
GL-S 9055c54
fixed-indentation
GL-S File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GL-S Could "appears to maximise" be replaced by "optimises" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I need assistance from @robbibt or @vnewey here. Because the source I have found say that NEAREST uses the nearest pixels, valid or invalid. So I am not sure it always optimises/maximises the visualisation, or if just happens to work for those products we applied it to.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some quick testing today, but essentially "nearest" was the only method that wouldn't come out empty if an overview pixel overlapped with a high-res single nodata pixel. So using "nearest" was less about maximising data coverage, but more to ensure our overviews contained at least some data.
I think we can probably go with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah ok, I just wanted to double check this. thanks for confirming!
If you observed it working better to show data, then the statement you suggest is correct. I think it's ok to just describe the effect of applying the algorithm without including too many details on how the algorithm works, considering there is a bit of confusion around it