Fix ODC 1.9 regression in DEA Products Wetland Insights Tool Notebook (WIP) #1403
Conversation
colourmeamused
requested review from
Ariana-B,
BexDunn,
GL-S,
JM-GA,
Kooie-cate,
LaurenSchenk1,
arcisad,
caitlinadams,
cbur24,
eloise-b,
erialC-P,
geoscience-aman,
jennaguffogg,
robbibt,
supermarkion and
vnewey
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
That's great Abeer! I am about to add just a couple of feedback comments for potential minor adjustments! |
| @@ -35,7 +35,13 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #11. # from datacube.utils.geometry import Geometry, CRS
Maybe worth it to remove the commented line, for a neater look
Reply via ReviewNB
| @@ -35,7 +35,13 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #2. # gpgon = datacube.utils.geometry.Geometry(poly.geometry[0], crs=poly.crs)
Similarly, it is probably less confusing to a user if the unused line is deleted completely. But I don't know if there is a specific reason to leave the option
Reply via ReviewNB
| @@ -35,7 +35,13 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #3. # time = ('1985-01-01', '2024-01-01')
Similar to the comments above. Although this was already there in the old version of the notebook.
Reply via ReviewNB
| @@ -35,7 +35,13 @@ | |||
| { | |||
There was a problem hiding this comment.
Converting this cell to markdown rather than raw should fix the visualisation of the table
Reply via ReviewNB
There was a problem hiding this comment.
This comment is referring to the table after the title "WIT CSV data specification table"
There was a problem hiding this comment.
Thanks @GL-S! I will do all these, except the time one that as you said is in the current notebook.
I had to pass the time param explicitly under ODC 1.9 in cell [7] or it runs over 1987-2025 (sloooow).
There was a problem hiding this comment.
This looks great @colourmeamused! We may revisit and remove the extra time query once this fix is rolled out in datacube (opendatacube/datacube-core#2192), but for now I think this is perfect.
|
@colourmeamused If you're happy with the notebook, feel free to merge with "Squash and merge"! 🙂 |
3 participants
This fixes ODC 1.9 regressions in the DEA_Wetlands_Insight_Tool notebook and should be ready to merge. I cleaned up all the cell output, should I run all the cells in DEA_Wetlands_Insight_Tool.pynb and push with output?