Skip to content

Conversation

@GL-S
Copy link
Collaborator

@GL-S GL-S commented Sep 25, 2025

Proposed changes

The new notebook shows how to load a DEA continental COG using different overviews and quickly shows the caveats of doing that for categorical data.

EDIT: the tests are failing, by the NB runs well in both default and unstable. I am not too sure why the tests fail.

Checklist

If this is a notebook, then have you:

  • Checked the structure of the notebook follows our DEA-notebooks template
  • Removed any unused Python packages from Load packages
  • Removed any unused/empty code cells
  • Removed any guidance cells (e.g. General advice)
  • Ensured that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Included relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Tested notebook on the DEA Sandbox
  • Cleared all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • If applicable, update the Notebook currently compatible with line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@GL-S GL-S marked this pull request as draft September 25, 2025 22:31
@GL-S
Copy link
Collaborator Author

GL-S commented Sep 25, 2025

Not sure why this is failing the tests. The notebook runs well in both default and unstable Sandbox

@GL-S GL-S marked this pull request as ready for review September 25, 2025 23:35
@GL-S
Copy link
Collaborator Author

GL-S commented Oct 13, 2025

@cbur24 , I made some minor adjustments to the text, changed the chart titles to automatically retrieve the resolution rather than hard coded, and renamed the other COG notebook as we were saying earlier

Copy link
Collaborator

@cbur24 cbur24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GL-S, looks ready to merge once the tests have passed.

@GL-S GL-S merged commit 85e1b2f into develop Oct 13, 2025
1 check passed
@GL-S GL-S deleted the work-with-cogs branch October 13, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants