adding utilities for handling shapes that cross the AM #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abradley60
commented
Oct 17, 2025
abradley60
commented
- Adding utilities for handling shapes that cross the antimeridian
- check if Polygons / MultiPolygons cross the antimeridian
- Provide functions to get the appropriate bounds if they do
- Add doc string to dem handler
- Clean and add new tests for functions
- Add an antimeridian example to the README.
caitlinadams
approved these changes
Oct 19, 2025
| f"Provided shape : {shape}" | ||
| ) | ||
|
|
||
| min_x = max(west_longitudes) |
There was a problem hiding this comment.
Suggested change
| min_x = max(west_longitudes) | |
| # For a valid set of bounds that cross the antimeridian, the minimum value of x corresponds to the maximum negative longitude in the western hemisphere; the maximum value of x corresponds to the minimum positive longitude in the eastern hemisphere. | |
| min_x = max(west_longitudes) |
|
|
||
| min_x = max(west_longitudes) | ||
| max_x = min(east_longitudes) | ||
| min_y = min(latitudes) |
There was a problem hiding this comment.
Suggested change
| min_y = min(latitudes) | |
| # minimum and maximum values of y correspond to the minimum and maximum latitudes. | |
| min_y = min(latitudes) |
| ) -> bool: | ||
| """Check if the provided bounds cross the antimeridian. The max width specifies | ||
| how large the width of the bounds can be across the antimeridian. For example | ||
| bounds with xmin=-176, xmax=170 has a width of 14 degrees across the antimeridian. |
There was a problem hiding this comment.
Suggested change
| bounds with xmin=-176, xmax=170 has a width of 14 degrees across the antimeridian. | |
| a set of bounds with xmin=-176, xmax=170 has a width of 14 degrees across the antimeridian. |
| how large the width of the bounds can be across the antimeridian. For example | ||
| bounds with xmin=-176, xmax=170 has a width of 14 degrees across the antimeridian. | ||
| The same bounds would stretch 346 degrees across the globe if an antimeridian crossing | ||
| if not considered. |
There was a problem hiding this comment.
Suggested change
| if not considered. | |
| is not considered. |
| the set of bounds (xmin, ymin, xmax, ymax) | ||
| max_scene_width : int, optional | ||
| maximum allowable width of the scene bounds in degrees, by default 20 | ||
| The set of bounds (xmin, ymin, xmax, ym : in_degrees, |
There was a problem hiding this comment.
Suggested change
| The set of bounds (xmin, ymin, xmax, ym : in_degrees, | |
| The set of bounds (xmin, ymin, xmax, ymax : in_degrees, |
|
|
||
| print(bounds) | ||
| >>> (-178.03, -71.61, 173.43, -68.76) | ||
| # bounds represent the eastern and western most point either side of the antimeridian |
There was a problem hiding this comment.
Suggested change
| # bounds represent the eastern and western most point either side of the antimeridian | |
| # bounds represent the eastern-most and western-most point either side of the antimeridian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.