Minor fixes to gn module #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclel
commented
Apr 11, 2024
aclel
commented
- Use auto_download_PPP functions instead of custom logic to download products from IGS
- Fix paths to dependencies in yaml template
- Georinex was missing from requirements.txt, and I'm not sure how this happened. It was included in the original pull request.
This function achieves the same result, so it's worth just using this one
georinex is used in gn module to parse rinex, it was missing from requirements.txt
ronaldmaj
reviewed
Apr 30, 2024
| erp=True, | ||
| clk=True, | ||
| bia=False, | ||
| gpt2=False, |
There was a problem hiding this comment.
You'll probably want to have this one on? Unless you grab this file from elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.