Fixed bugs in relative_TT_residuals_plotter #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' column when reading picks ensemble file into Pandas data frame. Fixed bug where script will crash if there are no common events (parameter df_plot = None). So just need to catch the df_plot = None case.
zhang01GA
reviewed
Jun 17, 2021
There was a problem hiding this comment.
Thanks Ashby for the PR. It looks all good to me except a bit of concern on the import changed to relative path: what if this script is run outside the seismic/gps_corrections/ directory? and in the scenario when seismic package is installed by a "pip install ".
zhang01GA
approved these changes
Jul 27, 2021
Hi Fei, yes I realised afterwards that the script was meant to be called from the top level directory. Disregard that import modification. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified imports to suit relative import. Fixed bug in missing 'phase' column when reading picks ensemble file into Pandas data frame. Fixed bug where script will crash if there are no common events (parameter df_plot = None). So just need to catch the df_plot = None case.