Skip to content

Conversation

@PussInDasBoot
Copy link
Collaborator

@PussInDasBoot PussInDasBoot commented Jun 16, 2025

Added some tests for stream processing. Just checking we are happy with this format before I continue to write more tests.

@PussInDasBoot PussInDasBoot self-assigned this Jun 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 17.61%. Comparing base (f395124) to head (b0ac566).

Files with missing lines Patch % Lines
...classifier/data_harvester/cataloguing-ISC-noise.py 0.00% 3 Missing ⚠️
...ic/ml_classifier/data_harvester/cataloguing-ISC.py 0.00% 3 Missing ⚠️
seismic/ml_classifier/data_harvester/getwave.py 0.00% 3 Missing ⚠️
seismic/ml_classifier/data_harvester/save-noise.py 0.00% 3 Missing ⚠️
.../ml_classifier/data_harvester/save-traces-SandP.py 0.00% 3 Missing ⚠️
.../ml_classifier/data_harvester/save-traces-justP.py 0.00% 3 Missing ⚠️
.../ml_classifier/data_harvester/save-traces-justS.py 0.00% 3 Missing ⚠️
seismic/ml_classifier/data_harvester/events.py 0.00% 1 Missing ⚠️
...mic/ml_classifier/data_harvester/save-traces-3D.py 0.00% 1 Missing ⚠️
...eismic/ml_classifier/data_harvester/save-traces.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #266       +/-   ##
============================================
- Coverage    60.17%   17.61%   -42.56%     
============================================
  Files           86      239      +153     
  Lines        10079    26017    +15938     
  Branches         0     4122     +4122     
============================================
- Hits          6065     4583     -1482     
- Misses        4014    21089    +17075     
- Partials         0      345      +345     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PussInDasBoot PussInDasBoot force-pushed the PV-2362-increase-test-coverage branch from 5f70b84 to a15b650 Compare June 16, 2025 07:14
@PussInDasBoot PussInDasBoot force-pushed the PV-2362-increase-test-coverage branch from 6300033 to c0e9d74 Compare June 17, 2025 00:42
@PussInDasBoot PussInDasBoot force-pushed the PV-2362-increase-test-coverage branch from 4b3bb01 to da61e7c Compare June 17, 2025 01:13
@PussInDasBoot PussInDasBoot force-pushed the PV-2362-increase-test-coverage branch from 32bb815 to 2b8d13e Compare June 17, 2025 01:20
@PussInDasBoot PussInDasBoot force-pushed the PV-2362-increase-test-coverage branch from 0ad03ce to d25b89b Compare June 17, 2025 01:55
@PussInDasBoot PussInDasBoot force-pushed the PV-2362-increase-test-coverage branch from b5484d0 to 81329aa Compare June 17, 2025 02:39
@PussInDasBoot PussInDasBoot force-pushed the PV-2362-increase-test-coverage branch from 36e1c5c to 2653a8d Compare June 18, 2025 23:44
@PussInDasBoot PussInDasBoot force-pushed the PV-2362-increase-test-coverage branch from e6342cd to 04f3abd Compare June 19, 2025 00:08
@PussInDasBoot PussInDasBoot requested a review from geojunky June 19, 2025 01:12
@PussInDasBoot PussInDasBoot marked this pull request as ready for review June 19, 2025 01:12
Copy link
Collaborator

@geojunky geojunky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, Melyn. It looks good, but please undo the changes made to test_stream_curation and test_stream_processing.

@geojunky geojunky merged commit a22a2cf into develop Jun 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants