Updates/asf netrc #105
Open
Updates/asf netrc #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caitlinadams
approved these changes
Oct 17, 2025
| asf_user=asf_user, | ||
| asf_password=asf_password, | ||
| ) | ||
| try: |
There was a problem hiding this comment.
Not for this PR, but I'm wondering if eof.download.main could use a tidy up? It's a bit unintuitive that it takes both CDSE and ASF credentials at this level, although that is explained with the comment. For readability, I would find it more intuitive if it attempted to download with CDSE credentials at the time where you check if source == "CDSE" -- however, I haven't looked at the function in detail, so there may be good reasons for having the downloader handle that logic.
| asf_scene_metadata.download(path=download_folder, session=session) | ||
| if use_session: | ||
| asf_scene_metadata.download(path=download_folder, session=session) | ||
| else: |
There was a problem hiding this comment.
Perhaps add a comment to explain that asf_scene_metadata will default to looking for the .netrc file if no session is provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asf_search.ASFSession.auth_with_creds(). See the related GH issue here - [Bug] Authentication issues with asf_search.ASFSession.auth_with_creds() asfadmin/Discovery-asf_search#396