Dem refactor #26
Merged
Dem refactor #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abradley60
commented
Mar 3, 2025
abradley60
commented
- Removing dem code from nci specific folders
- Moving utils to dem specific folders, nci/aws components not do depend on these
- updating lots of paths
caitlinadams
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Thanks @abradley60 -- this looks good. I removed unused imports and tidied up some of the type hinting. Ready to merge, and then split.
abradley60
added a commit
that referenced
this pull request
Apr 10, 2025
- Removing dem code from nci specific folders - Moving utils to dem specific folders, nci/aws components not do depend on these - updating lots of paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.