Feature/burst db #33
Merged
Feature/burst db #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abradley60
commented
Mar 25, 2025
abradley60
commented
- Shell scripts to create and upload the burst database to a specified S3 bucket
- Docs that describe the process
- The burst-db is not currently referenced/used in the project. This will come at a later date and correspondingly to 'todo's' will be updated.
- For now this serves as a repeatable way to create/update the burst-db for our pipelines
caitlinadams
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Looks good to me -- I've added minor comments just noting that we may want to switch from conda to pixi at some future time for consistency in the project, but that can be sometime in the future (and also not a big deal, since I'm guessing most of this will be set up with a GitHub action)
| echo "Update using the BURST_DB_VERSION_TAG input if required" | ||
|
|
||
| # Check if conda command exists | ||
| if command -v conda &> /dev/null |
There was a problem hiding this comment.
This might need to be re-done if we move to pixi
| cd burst_db | ||
|
|
||
| # Create a new conda environment | ||
| conda create --name burst-db-v"$BURST_DB_VERSION_TAG" python=3.10 -y |
There was a problem hiding this comment.
Similarly, may need redoing if we move to pixi
caitlinadams
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Thanks @abradley60 -- looks good to me. The echo statements warning that the Dockerfile needs to be updated should serve us until we decide what to do operationally :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.