Add ETAD processing to NCI Pipeline #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
caitlinadams
commented
Apr 2, 2025
caitlinadams
commented
- Add functions for finding and downloading ETAD files from CDSE
- Update CLI to work with --etad-dir option (ETAD is not used if this option is not provided)
- Update to CLI to take all options through
…d include a dry-run argument
abradley60
reviewed
Apr 3, 2025
| corrected_scene_dir = uncorrected_scene.parent / "etad_corrected" | ||
|
|
||
| if not (etad.is_dir() and etad.suffix == ".SAFE"): | ||
| logging.info("Atte") |
There was a problem hiding this comment.
Just checking "Atte"means something?
There was a problem hiding this comment.
Haha, nope, clearly left my keyboard halfway through. Will work out a sensible message!
There was a problem hiding this comment.
lol nah I like Atte!!
abradley60
reviewed
Apr 3, 2025
sar_pipeline/preparation/etad.py
Outdated
| raise ValueError(f"No ETAD products found. Scene start date: {scene_start}") | ||
| elif len(search_results) > 1: | ||
| raise ValueError( | ||
| f"{len(search_results)} ETAD products found, which is too many. Review files: {[result['Name'] for result in search_results]}" |
There was a problem hiding this comment.
Minor, but could explicitly state that 1 is expected rather than too many
abradley60
reviewed
Apr 3, 2025
| """ | ||
|
|
||
| # Validate that input scene and etad are .SAFE directiories | ||
| if not (scene.is_dir() and scene.suffix == ".SAFE"): |
There was a problem hiding this comment.
Is there reason for not doing this on the users behalf?
There was a problem hiding this comment.
I was trying to keep the function simple and limited in scope. I handle the unzipping as part of the application (i.e. pyrosar_geocode).
|
Looks good as is! Address comments if you think needed otherwise go ahead for merge |
abradley60
pushed a commit
that referenced
this pull request
Apr 10, 2025
Add ETAD processing to NCI Pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.