STAC update #38
Merged
STAC update #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abradley60
commented
Apr 3, 2025
abradley60
commented
- Updating STAC metadata based on first review of compliance
- Still some TODO's which are clearly flagged. Bringing changes in to main and TODO's will get sorted as we progress.
caitlinadams
reviewed
Apr 3, 2025
| ) | ||
|
|
||
| # add ceosard stac extension properties | ||
| self.item.properties["ceosard:type"] = "NRB" |
There was a problem hiding this comment.
If you have product:type, does that make ceosard:type redundant (or vice-versa)? Or is it expected that a product has both?
There was a problem hiding this comment.
Yeah I did notice this, I think will keep both for now and we can follow up. I think the product:type could be changed to RTC_S1 given the ceosard:type covers the spec
| logger = logging.getLogger(__name__) | ||
|
|
||
| VALID_BASE_CONFIGS = ["S1_RTC.yaml","S1_RTC_STATIC.yaml"] | ||
| VALID_BASE_CONFIGS = ["S1_RTC.yaml", "S1_RTC_STATIC.yaml"] |
There was a problem hiding this comment.
Given you've now added this, I think it makes sense to update the type hinting of RTCConfigManager to a Literal to help with type checking. Suggested approach is to define the literal first, then build the constant from it:
import typing
from typing import Literal
BaseConfigType = Literal["S1_RTC.yaml", "S1_RTC_STATIC.yaml"]
VALID_BASE_CONFIGS = typing.get_args(BaseConfigType)
Co-authored-by: Caitlin Adams <[email protected]>
caitlinadams
approved these changes
Apr 3, 2025
abradley60
pushed a commit
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.