-
Notifications
You must be signed in to change notification settings - Fork 2
rema integration #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rema integration #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex!
docs/workflows/aws.md
Outdated
|
|
||
| ```bash | ||
| docker run --env-file env.secret -it sar-pipeline --scene S1A_IW_SLC__1SSH_20220101T124744_20220101T124814_041267_04E7A2_1DAD --output_crs 3031 --burst_id_list t070_149815_iw3 | ||
| docker run --env-file env.secret -it sar-pipeline --scene S1A_IW_SLC__1SSH_20220101T124744_20220101T124814_041267_04E7A2_1DAD --output_crs 3031 --burst_id_list t070_149815_iw3 --skip_upload_to_s3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking - if you want to test locally like you are here with the --skip_upload_to_s3 flag, wouldn't you want to set make_existing_products = True? To tell it to not look at existing products on S3, because you're not going to upload there anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea, I'll change to reflect
docs/workflows/aws.md
Outdated
| - `resolution` -> The target resolution of the products. Default is 20m. | ||
| - `output_crs` -> The target crs of the products. If not specified, the UTM of the scene center will be used. Expects integer values (e.g. 3031) | ||
| - `dem` -> The dem to be used in processing. Supported is `cop_glo30`. | ||
| - `dem_type` -> The dem to be used in processing. Supported is [`cop_glo30`, `REMA_32`, `REMA_10`, `REMA_2`]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest
The digital elevation model (DEM) to use for processing. Supported values: cop_glo30, REMA_32, REMA_10, REMA_2.
docs/workflows/aws.md
Outdated
| - `s3_project_folder` -> The project folder to upload to. | ||
| - `collection` -> The collection which the set of products belongs. | ||
| - `make_existing_products` -> If products should be made, even if they already exist in S3. | ||
| - **WARNING**, - Setting will create duplicate files and overwrite metadata that will impact downstream processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest
Whether to generate products even if they already exist under the s3_bucket/s3_project_folder/collection.
WARNING - Passing this flag will create duplicate files and overwrite existing metadata, which may affect downstream workflows.
| @click.option( | ||
| "--dem-type", | ||
| required=True, | ||
| type=click.Choice(["cop_glo30", "REMA_32", "REMA_10", "REMA_2"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a help statement here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- one minor comment suggesting adding a help statement for the CLI for dem_type
Uh oh!
There was an error while loading. Please reload this page.