Upgrades/stac #67
Merged
Upgrades/stac #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abradley60
requested review from
caitlinadams and
geoscience-aman
and removed request for
geoscience-aman
docs/workflows/aws.md
Outdated
| --s3_bucket="deant-data-public-dev" | ||
| --s3_project_folder="experimental" | ||
| --collection="s1_rtc_c1" | ||
| --collection_number=1 |
There was a problem hiding this comment.
Can we get the collection_number from the collection to avoid a situation where we accidentally have the two variables set to different values?
There was a problem hiding this comment.
Yeah I did think that but the collection can be set arbitrarily. Perhaps I should change it so the collection always has to end with cX, where X is the collection number?
There was a problem hiding this comment.
Sounds good to me :)
caitlinadams
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding collection_number as an input to set the odc product that will be indexedcollectionto end in cX where X is an integer corresponding to the collection number. Logic helps set odc parameters and ensure collection formatting is consistent.