Alter download scene functions to work from scene ID #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abradley60
reviewed
Jun 19, 2025
|
Looks good! |
abradley60
approved these changes
Jun 19, 2025
geoscience-aman
approved these changes
Jun 19, 2025
| r"(\d{8}T\d{6})_" # Stop datetime | ||
| r"(\d{6})_" # Orbit number (000000–999999) | ||
| r"((?!000000)[A-F0-9]{6})_" # Data-take ID: non-zero hex | ||
| r"([A-F0-9]{4})" # CRC16 and extension |
There was a problem hiding this comment.
It might be good to do r"([A-F0-9]{4})$" # CRC16 and extension with the dollar sign or a fullmatch in extract_metadata_from_s1_id().
Otherwise "S1A_IW_SLC__1SDV_20201019T191827_20201019T191854_034869_0410AD_29DE.stuff" is treated as a valid ID, for example.
|
Thank you Caitlin 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update converts the
download_slc_from_asfanddownload_slc_from_cdseto more generic versions of the functions that read the metadata contained in the provided ID and downloads the file.This includes separating out the query step (which does not require credentials) into its own function so that it can be easily tested.
This allows us to download GRD files as well as SLC files, which is valuable for EW processing.