Skip to content

Conversation

@abradley60
Copy link
Collaborator

@abradley60 abradley60 commented Jun 25, 2025

Large PR with many changes...

  • Additional protection against duplication. i.e. check file exists just before uploading
  • Adding clarity to logic for burst_id_list_to_process. i.e. if a burst_id_list is passed in and some already exist, burst_id_list_to_process will only include the missing bursts
  • Adding exit codes:
    • 101 : The required static layers for linking do not exist
  • Changing logic so the s3 bucket can still be queried if credentials aren't passed
  • Adding early tests
    • test-aws-cli -> requires credentials to be set
    • test-aws-functions -> unit testing for individual functions
    • test-full-aws-docker-run -> end to end build and test of the image, should be run before releasing
  • removing interpolated_dem from the required static layers
  • Improving logic to just get DEM for required burst area
  • Adding gamma0 to the backscatter assets. i.e HH.tf -> HH_gamma0.tif
  • spliting logic into an odc specific file for odc and s3 upload path related things
  • Updating s3 paths
  • Fixing burst geometries in metadata

@abradley60 abradley60 changed the title Upgrade/duplication Upgrade/duplication and tests Jun 25, 2025
@abradley60 abradley60 changed the title Upgrade/duplication and tests Upgrades - duplication protection and tests Jun 25, 2025
@abradley60 abradley60 marked this pull request as ready for review June 29, 2025 23:27
Copy link
Collaborator

@geoscience-aman geoscience-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests and everything 🙏

Copy link
Collaborator

@caitlinadams caitlinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of this work, @abradley60 -- it's fantastic to have more tests included. I've made some minor suggestions throughout, see what you think.

Copy link
Collaborator

@caitlinadams caitlinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@caitlinadams caitlinadams merged commit 824c614 into main Jul 1, 2025
2 checks passed
@caitlinadams caitlinadams deleted the upgrade/duplication branch July 1, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants