-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrades - duplication protection and tests #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tests and everything 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of this work, @abradley60 -- it's fantastic to have more tests included. I've made some minor suggestions throughout, see what you think.
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
Large PR with many changes...
burst_id_list_to_process. i.e. if aburst_id_listis passed in and some already exist,burst_id_list_to_processwill only include the missing bursts101: The required static layers for linking do not existtest-aws-cli-> requires credentials to be settest-aws-functions-> unit testing for individual functionstest-full-aws-docker-run-> end to end build and test of the image, should be run before releasinginterpolated_demfrom the required static layersgamma0to the backscatter assets. i.eHH.tf->HH_gamma0.tif