Skip to content

Conversation

@abradley60
Copy link
Collaborator

@abradley60 abradley60 commented Jul 9, 2025

  • reference the new GA RTC project with updates
    • main changes include bumping isce3 version and updating product metadata to reference GA processes
  • Default to always validate the stac doc
  • Adding geolocation accuracy values
  • Write bursts to a geojson for debugging
  • Updating tests to first create static layers, and then link them

--scene_data_source="CDSE"
--orbit_data_source="CDSE"
--validate_stac=false
--skip_validate_stac=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you happy enough with your testing for validating the STAC document for this to be the default behaviour?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, if we start with a week or so of data for the first run we can see if it falls over anywhere?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do the STAC validation outside the container for our testing to not waste processed datasets?

Copy link
Collaborator Author

@abradley60 abradley60 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but that would imply the product is also valid even if the STAC isn't. IMO best way forward is to do some testing and see if the validation fails anywhere. if it looks like a considerable issue, we can maybe do what you suggest. What you think? I'm not sure retrospectively fixing stac docs is a good way forward either way

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with that approach :)

Let's see how it goes.

all_scene_burst_info[id_]["geometry"] for id_ in burst_id_list_to_process
]
# write the geometries to a geojson. Useful for debugging if needed
write_burst_geometries_to_geojson(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to have this as optional if it's only for debugging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep probably a good idea

@geoscience-aman
Copy link
Collaborator

Thank you Alex! Exciting new release.

@geoscience-aman geoscience-aman self-requested a review July 9, 2025 06:44
Copy link
Collaborator

@caitlinadams caitlinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@abradley60 abradley60 merged commit d5b572b into main Jul 9, 2025
2 checks passed
@caitlinadams caitlinadams deleted the upgrade/GA_docker_image branch July 9, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants