-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade/ga docker image #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| --scene_data_source="CDSE" | ||
| --orbit_data_source="CDSE" | ||
| --validate_stac=false | ||
| --skip_validate_stac=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you happy enough with your testing for validating the STAC document for this to be the default behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, if we start with a week or so of data for the first run we can see if it falls over anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do the STAC validation outside the container for our testing to not waste processed datasets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but that would imply the product is also valid even if the STAC isn't. IMO best way forward is to do some testing and see if the validation fails anywhere. if it looks like a considerable issue, we can maybe do what you suggest. What you think? I'm not sure retrospectively fixing stac docs is a good way forward either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with that approach :)
Let's see how it goes.
sar_pipeline/aws/cli.py
Outdated
| all_scene_burst_info[id_]["geometry"] for id_ in burst_id_list_to_process | ||
| ] | ||
| # write the geometries to a geojson. Useful for debugging if needed | ||
| write_burst_geometries_to_geojson( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to have this as optional if it's only for debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep probably a good idea
|
Thank you Alex! Exciting new release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks!
Uh oh!
There was an error while loading. Please reload this page.