Fix spelling errors and type hinting in NCI code #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abradley60
reviewed
Jul 16, 2025
| outdir=str(processing_directories["scene"]), | ||
| spacing=geocode_spacing, | ||
| scaling=geocode_scaling, | ||
| scaling=geocode_pyrosar_scaling, # type: ignore |
There was a problem hiding this comment.
Just making sure the comment should be here
There was a problem hiding this comment.
Yep -- it's because pyroSAR doesn't do type-hinting, and has a string as a default parameter. However, its docstrings say it accepts both a string and a list of strings. I assigned it to a new variable to clean up a different linting error, but couldn't get rid of this one.
abradley60
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor PR to address spelling errors and type-hinting/linting issues that have come up during development. All changes should have no affect on functionality.