Skip to content

Conversation

@abradley60
Copy link
Collaborator

Copy link
Collaborator

@geoscience-aman geoscience-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one.

Copy link
Collaborator

@caitlinadams caitlinadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from the suggestion that we further update the odc product name.

"""get the odc product name. WARNING this must align with
the DEA product name at indexing into the datacube.
These are hard-coded and set by the provided `collection_number`.
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed adding "nrb" to the product name, which will allow us to potentially index other ARD products in future. So perhaps the names below need to change to ga_s1_nrb_iw_vv_vh_c0 etc?

@abradley60 abradley60 merged commit c05e694 into main Jul 22, 2025
2 of 3 checks passed
@abradley60 abradley60 deleted the upgrades/s3_path branch August 22, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants