-
Notifications
You must be signed in to change notification settings - Fork 2
Improvements to S3 paths #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me apart from the suggestion that we further update the odc product name.
| """get the odc product name. WARNING this must align with | ||
| the DEA product name at indexing into the datacube. | ||
| These are hard-coded and set by the provided `collection_number`. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed adding "nrb" to the product name, which will allow us to potentially index other ARD products in future. So perhaps the names below need to change to ga_s1_nrb_iw_vv_vh_c0 etc?
collectionis no longer specified, acollection_numberis given