-
Notifications
You must be signed in to change notification settings - Fork 2
Updates/source data preferences #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Alex, looking good.
|
|
||
| ## Workflows | ||
|
|
||
| For more information see [Workflows](docs/workflows/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR but can you please rename the current docs/workflows/README.MD to README.md for the link to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done nice pickup
| float(self.h5.search_value("centerFrequency")) / 1e9 | ||
| ) # GHz | ||
| self.item.properties["sarard:center_frequency_unit"] = "GHz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CEOS metadata spec wants the center frequency in Hz?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another conflict, the sar-extension wants it in GHz which is why I changed it. Given the xml will have us covered should I leave it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the ability to use AusCopHub. My suggestions are minor and relate to making sure documentation is consistent with the API. The tests you've added look good to me.
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
Co-authored-by: Caitlin Adams <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
Changes
pygssearchpackage. Unfortunately, this cannot be installed in thesar-pipelineenvironment due to numerous package conflicts that break the workflow. The solution has been to create an additional conda environment (pygssearch-env) that gets called from a subprocess. pygssearch is a command line tool and is called as such. This new envrionment is defined in a basicenvrionment-pygssearch.yamlfile--scene_data_sourcecan be one ofASF,AUS_COP_HUB,CDSE, or a space separated list of preferences--orbit_data_sourcecan be one ofASF,CDSE, or a space separated list of preferences