Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement comment feature for activities #158

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Wenxiu332
Copy link

create comment model, add comment box, add template for viewing comments for activities

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2022

CLA assistant check
All committers have signed the CLA.

@brylie
Copy link
Member

brylie commented Nov 23, 2022

Thanks :-) Could you also attach a screenshot of the activity discussions to this PR description?

@brylie
Copy link
Member

brylie commented Nov 24, 2022

@Wenxiu332, could you post a screen grab of the Companionship Care UI showing an activity discussion? I.e., a picture of the code you are working on as it renders in the Companionship Care user interface.

@Wenxiu332
Copy link
Author

sure, here's "add comment" button on the circle_activity.html page and the comment_detail.html page for a particular activity once user click "view comment"
Screen Shot 2022-11-24 at 10 01 35 AM
Screen Shot 2022-11-24 at 10 12 01 AM

@Wenxiu332
Copy link
Author

@brylie hi, is there any other modifications you need from me?

@brylie
Copy link
Member

brylie commented Nov 29, 2022

@Wenxiu332, no further commits are needed. I will do some design work to communicate how the discussion feature should work. Thanks for your contribution so far :-)

@brylie brylie marked this pull request as draft November 29, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants