integration.sh: stop reading any nonzero exit as a gateway rejection - #4
Open
MattJackson wants to merge 1 commit into
Open
integration.sh: stop reading any nonzero exit as a gateway rejection#4MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
The else branch treated ANY nonzero exit from the gateway call as the expected rejection. Run against a stub binary with no `config apply` subcommand at all — a plausible state after a CLI rename — and the script printed INTEGRATION OK and exited 0, having proven nothing about the gateway. Only a real rejection (recognised by its message) is tolerated now; anything else fails. Unrelated but worth recording, since another agent owns the fix: the spec-drift job still compares info.version strings and still exits 0 when the GitHub API is unreachable. I verified the compensating control — the 769-line conformance suite that shipped on this branch — and it is sound: it checks shapes, not version strings, so the risk is contained today. The gate itself is still green about a property it does not check, so it stays on the list until it compares shapes rather than a version number that both sides can claim identically while having diverged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No check goes red as a result of this change. Part of a fleet-wide sweep for checks that report GREEN without having checked anything (21 found, 17 proven).
The finding
The
elsebranch treated any nonzero exit from the gateway call as the expected rejection. Run against a stub binary with noconfig applysubcommand at all — a plausible state after a CLI rename — and the script printedINTEGRATION OKand exited 0, having proven nothing about the gateway. Only a recognised rejection is tolerated now; anything else fails.Proven: constructed the stub, captured
INTEGRATION OK/ exit 0; the fixed script fails against that same stub and passes against a real gateway.On
spec-drift— not fixed here, and it stays on the listAnother agent owns this. Recording what I verified, since it is useful evidence for them:
info.versionstrings, and still exits 0 when the GitHub API is unreachable.1.5.3identically while having diverged, which is exactly how this was found. The gate is green about a property it does not check, and being compensated elsewhere does not make the gate correct.