release.yml: assert the asset check actually examined an asset - #6
Open
MattJackson wants to merge 1 commit into
Open
release.yml: assert the asset check actually examined an asset#6MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
The verification loop iterated a discovered asset list and asserted nothing when that list came back empty — an API hiccup or a renamed asset pattern and the release verified clean having inspected nothing. Floored on the count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No check goes red as a result of this change. Part of a fleet-wide sweep for checks that report GREEN without having checked anything (21 found, 17 proven).
The release-asset verification loop iterated a discovered asset list and asserted nothing when that list came back empty. An API hiccup or a renamed asset pattern, and the release verified clean having inspected nothing — "for each asset, assert it is well-formed" is true with zero assets.
Floored on the count. Proven: emptied the discovered set, watched the check report clean and exit 0; the fixed version fails against that same state and passes once the assets are back.
This is the same defect class as the plugin-repo findings in the sweep;
hashicorp-vaultis ondevso it is fixed here directly, while the nine plugin repos sitting onci/public-hygiene-greenwere left untouched and their patches handed over as diffs.