Make Poll Results Dialog Shows All Votes with Pagination Support #6043
+1,944
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for displaying poll results. It handles fetching poll votes with pagination. The following new classes have been added to support this controller: - `PollResultsViewState` to represent the different states of the view (Loading, Content, Error). - `PollResultsViewAction` for user actions like requesting to load more votes. - `PollResultsViewEvent` for events from the controller, such as load errors. Unit tests for `PollResultsViewController` have also been added to ensure its correctness.
…g ModalBottomSheet, which provides similar and improved animation, without the padding issue.
The `PollResultsViewState` is simplified from a sealed interface with `Loading`, `Content`, and `Error` states to a single data class. This change streamlines state management by using boolean flags like `isLoading` and `isLoadingMore`. Error handling is now managed through a separate event channel, and the query limit for fetching poll votes has been increased.
The `PollResultsViewState` is simplified from a sealed interface with `Loading`, `Content`, and `Error` states to a single data class. This change streamlines state management by using boolean flags like `isLoading` and `isLoadingMore`. Error handling is now managed through a separate event channel, and the query limit for fetching poll votes has been increased.
… to the PollResultsViewController
…ogic in the remaining previews.
This change refactors how the `Poll` object is passed to the `PollResultsDialogFragment` to prevent crashes during process recreation. The `Poll` object is now stored in a static map within the companion object, and its ID is passed through the fragment's arguments. Reference counting is used to manage the lifecycle of the poll object in the map, ensuring it's cleared when no longer needed. This avoids serializing the large `Poll` object directly into the arguments bundle.
Contributor
SDK Size Comparison 📏
|
andremion
changed the title
|
andremion
changed the title
...at-android-compose/src/main/java/io/getstream/chat/android/compose/ui/util/ViewModelStore.kt
Show resolved
Hide resolved
.../main/kotlin/io/getstream/chat/android/ui/common/state/messages/poll/PollResultsViewState.kt
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollViewResultDialog.kt
Outdated
Show resolved
Hide resolved
|
|
||
| item { Spacer(modifier = Modifier.height(16.dp)) } | ||
| if (state.isLoading || state.isLoadingMore) { | ||
| LoadingIndicator(modifier = Modifier.fillMaxSize()) |
Contributor
There was a problem hiding this comment.
Wouldn't this be shown over the list of votes? Is that intentional?
Contributor
Author
There was a problem hiding this comment.
Yes. It is shown for the initial load and the pagination loads.
The idea was not to show only the loading UI and block the user, since we already have an initial poll object (which contains 10 max votes).
Contributor
There was a problem hiding this comment.
Bit strange if you ask me... Maybe this is something to bring up for the upcoming design refresh?
Contributor
Author
There was a problem hiding this comment.
Sure.
What UX would you suggest?
Contributor
There was a problem hiding this comment.
I don't really have any good suggestions... Based on how the pagination works in this case, we cannot really know where to show a loading placeholder, so any assumptions could be wrong.
...o/getstream/chat/android/ui/feature/messages/list/internal/poll/PollResultsDialogFragment.kt
Show resolved
Hide resolved
Contributor
|
I think the wrong ticket is linked here, should be: AND-953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix poll results dialogs showing only 10 votes when polls have more votes. The
/channels/{type}/{id}/queryendpoint returns a limited number of latest votes inlatest_votes_by_option, while the totalvote_countcan be higher.Closes https://linear.app/stream/issue/AND-953
🛠 Implementation details
PollResultsViewControllerinui-commonto manage poll results state and pagination/polls/{poll_id}/votesendpoint (page size: 25, same as iOS)PollResultsViewModelfor both Compose and XML SDKsPollViewResultDialog(Compose) to use ViewModel withModalBottomSheetfor proper window insetsPollResultsDialogFragment(XML) withNestedScrollViewPaginationHelperfor pagination🎨 UI Changes
xml_before.webm
xml_after.webm
compose_before.webm
compose_after.webm
🧪 Testing