feat: introduce extended reaction list to a reactions detail component#3100
Open
arnautov-anton wants to merge 6 commits intomasterfrom
Open
feat: introduce extended reaction list to a reactions detail component#3100arnautov-anton wants to merge 6 commits intomasterfrom
arnautov-anton wants to merge 6 commits intomasterfrom
Conversation
8439fd4 to
bee5e5e
Compare
|
Size Change: +1.99 kB (+0.32%) Total Size: 617 kB 📦 View Changed
ℹ️ View Unchanged
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3100 +/- ##
==========================================
+ Coverage 82.21% 82.26% +0.05%
==========================================
Files 418 418
Lines 12044 12074 +30
Branches 3875 3882 +7
==========================================
+ Hits 9902 9933 +31
+ Misses 2142 2141 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
073fe31 to
cffb7d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.figma.com/design/Us73erK1xFNcB5EH3hyq6Y/Chat-SDK-Design-System?node-id=4305-171859&m=dev
New
ComponentContextslot:ReactionSelectorExtendedListA new optional component override has been added to
ComponentContextValue:This allows consumers to replace the extended reaction list UI (the grid of all available reactions) independently of the
ReactionSelectorcomponent itself. BothReactionSelectorandMessageReactionsDetailnow consume this slot from context, falling back toReactionSelector.ExtendedListwhen not provided. Pass it via<Channel ReactionSelectorExtendedList={YourComponent} />.Bug fix:
reactionDetailsSortprop now forwarded toMessageReactionsDetailThe
reactionDetailsSortprop onMessageReactionswas accepted but silently ignored (the destructured value was unused, suppressed with an eslint-disable comment). It is now correctly forwarded to theMessageReactionsDetailchild component, meaning custom sort orders for the reaction detail user list will take effect.New i18n key:
"Add reaction"A new translatable string
"Add reaction"has been added to all 12 locale files. It is used as thearia-labelon the "add reaction" button insideMessageReactionsDetail. Custom translation bundles should include this key.Styling changes
Three CSS changes in
MessageReactionsDetail.scss:var(--size-12)tovar(--size-16).rgba(0,0,0,0.1)tovar(--background-core-elevation-0), making it theme-aware.var(--spacing-xs)tovar(--spacing-md).Consumers who override these styles with selectors targeting
.str-chat__message-reactions-detaildescendants may need to adjust.