Skip to content

Fix mark unread action not removed when read events are disabled #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented May 6, 2025

🔗 Issue Links

https://linear.app/stream/issue/IOS-812/swiftui-mark-as-unread-feature-should-be-disabled-if-read-events-are

🎯 Goal

Fix mark unread action not removed when read events are disabled

🧪 Manual Testing Notes

  1. Go to Stream Dashboard of SwiftUI Demo App
  2. Go to Channel Types
  3. Go to Messaging
  4. Disable read events
  5. Go to the Demo App
  6. Long tap a message from another user
  7. Should not have mark unread action

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira requested a review from a team as a code owner May 6, 2025 18:20
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented May 6, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.18 MB 8.18 MB 0 KB 🟢

@martinmitrevski
Copy link
Contributor

There are some failing tests that need checking before merging

@nuno-vieira nuno-vieira enabled auto-merge (squash) May 7, 2025 12:23
@nuno-vieira nuno-vieira merged commit 546e6c7 into develop May 7, 2025
12 checks passed
@nuno-vieira nuno-vieira deleted the fix/mark-unread-action-not-removed-when-events-disabled branch May 7, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants