Allow customisation of message previews in lists #839
Conversation
laevandus
force-pushed
the
message-preview-customisation
branch
from
3432039 to
5b21d5f
Compare
SDK Size
|
| /// Provides message preview representation for lists. | ||
| public protocol MessagePreviewFormatting { | ||
| /// Formats the message including the author's name. | ||
| func format(_ previewMessage: ChatMessage, in channel: ChatChannel) -> String | ||
| /// Formats only the content of the message without the author's name. | ||
| func formatContent(for previewMessage: ChatMessage, in channel: ChatChannel) -> String | ||
| /// Formats only the attachment content of the message in case it contains attachments. | ||
| func formatAttachmentContent(for previewMessage: ChatMessage, in channel: ChatChannel) -> String? | ||
| } |
There was a problem hiding this comment.
I think it is probably better to just use the MessagePreviewFormatter function directly here 🤔 There is a chance we add new function here, for example, for Draft Message etc... and if we introduce a new function, it will be a breaking change.
There was a problem hiding this comment.
The other formatters, we use a protocol, but usually it is just one function, and for one use case. This one is a bit different, since we use it in multiple places, and there is a chance to extend it further
There was a problem hiding this comment.
It's also fine like this, you can add a protocol extension with a default implementation to avoid breaking changes.
There was a problem hiding this comment.
I did consider skipping the protocol part completely, but then only added it because many existing types in Utils had it. I guess it makes sense to skip it here.
There was a problem hiding this comment.
OK, let's go for no protocol here
There was a problem hiding this comment.
Yeah the default extension is a good point, forgot about it. In that case I'm fine with both approaches 👍
|
🔗 Issue Links
Resolves: IOS-895
🎯 Goal
📝 Summary
MessagePreviewFormatter🛠 Implementation
MessagePreviewFormatter🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-contentrepo