Skip to content

fix(llc): Fix TranscriptionSettingsResponse.fromJson null handling#1224

Merged
Brazol merged 1 commit intomainfrom
fix/fix-translation-null-language
Apr 28, 2026
Merged

fix(llc): Fix TranscriptionSettingsResponse.fromJson null handling#1224
Brazol merged 1 commit intomainfrom
fix/fix-translation-null-language

Conversation

@Brazol
Copy link
Copy Markdown
Contributor

@Brazol Brazol commented Apr 27, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a crash that occurred when transcription settings received an empty or null language value from the backend. The app now gracefully handles this scenario with a sensible default.

@Brazol Brazol requested a review from a team as a code owner April 27, 2026 16:17
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 76b046de-9022-4261-ac59-e26b13b8c61e

📥 Commits

Reviewing files that changed from the base of the PR and between 4a2e21a and e71a36f.

📒 Files selected for processing (2)
  • packages/stream_video/CHANGELOG.md
  • packages/stream_video/lib/open_api/video/coordinator/model/transcription_settings_response.dart

📝 Walkthrough

Walkthrough

This pull request fixes a null-check error in TranscriptionSettingsResponse.fromJson that occurred when the backend provides an empty string for the language field. The fix applies a null-coalescing operator to default to the auto enum value, with a corresponding CHANGELOG entry documenting the fix.

Changes

Cohort / File(s) Summary
Documentation
packages/stream_video/CHANGELOG.md
Added entry documenting the bug fix for TranscriptionSettingsResponse.fromJson null-check error handling.
Bug Fix
packages/stream_video/lib/open_api/video/coordinator/model/transcription_settings_response.dart
Updated fromJson to handle null language values using null-coalescing operator, defaulting to auto enum value instead of forced non-null assertion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A null came hopping through the code,
Making transcriptions fall and load!
With a gentle coalesce and auto's grace,
We caught that null and set its place.
Language flows like carrots now,
From empty strings—we've fixed it, wow! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author; the required template sections are entirely missing. Add a comprehensive description following the template, including Goal, Implementation details, Testing explanation, and required Contributor Checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main fix: addressing null handling in TranscriptionSettingsResponse.fromJson method.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fix-translation-null-language

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 5.77%. Comparing base (4a2e21a) to head (e71a36f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dinator/model/transcription_settings_response.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1224   +/-   ##
=====================================
  Coverage   5.77%   5.77%           
=====================================
  Files        676     676           
  Lines      49335   49325   -10     
=====================================
  Hits        2848    2848           
+ Misses     46487   46477   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Brazol Brazol merged commit 3157651 into main Apr 28, 2026
15 of 16 checks passed
@Brazol Brazol deleted the fix/fix-translation-null-language branch April 28, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants