Skip to content

feat: Set bundlePolicy for the peerconnection#923

Merged
renefloor merged 2 commits intomainfrom
feature/set-bundlePolicy-pc
Apr 8, 2025
Merged

feat: Set bundlePolicy for the peerconnection#923
renefloor merged 2 commits intomainfrom
feature/set-bundlePolicy-pc

Conversation

@renefloor
Copy link
Copy Markdown
Contributor

@renefloor renefloor commented Apr 2, 2025

Fixes FLU-91

🎯 Goal

RTP BUNDLE is a mechanism in RTP that enables using a single socket/connection to send multiple media types.

This is typically used to send audio and video over the same connection, and allows reducing the number of opened sockets and pinholes that need to be managed and reduces the resources required to get a session work through a firewall or NAT device.

🛠 Implementation details

Sets the bundlePolicy and includes a unit test

🎨 UI Changes

No UI change

🧪 Testing

Added a test to verify the field is set. We should do some manual call tests

☑️Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

@renefloor renefloor requested a review from a team as a code owner April 2, 2025 12:56
Copy link
Copy Markdown
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renefloor renefloor merged commit e2f8031 into main Apr 8, 2025
7 checks passed
@renefloor renefloor deleted the feature/set-bundlePolicy-pc branch April 8, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants