NeoForge Platform Support #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will close #2502 |
Konicai
reviewed
Jun 18, 2023
| @@ -42,4 +42,4 @@ public abstract class PathPackCodec extends PackCodec { | |||
| */ | |||
| @NonNull | |||
| public abstract Path path(); | |||
| } | |||
| } | |||
...rap/mod/src/main/java/org/geysermc/geyser/platform/mod/command/GeyserModCommandExecutor.java
Outdated
Show resolved
Hide resolved
|
Is this still being worked on? Or can this be closed? I need to have a Geyser Jar for Forge. |
|
@Atten007 There is no ETA on the merge for now. We have lifes outside of Geyser (sorry ^^). |
Camotoy
added
PR: On hold
|
This PR will likely remain on hold until post-1.20.2 as we see how the modding community (which we're not really a part of) evolves with the Forge/NeoForge split. |
Merged
Konicai
removed
the
Waiting For Minecraft Update
…tform # Conflicts: # .github/workflows/build.yml # api/src/main/java/org/geysermc/geyser/api/util/PlatformType.java # bootstrap/fabric/src/main/resources/geyser-fabric.mixins.json # bootstrap/mod/src/main/java/org/geysermc/geyser/platform/mod/command/ModCommandSender.java # build-logic/src/main/kotlin/geyser.base-conventions.gradle.kts # build-logic/src/main/kotlin/geyser.modded-conventions.gradle.kts # core/src/main/java/org/geysermc/geyser/session/GeyserSession.java # gradle.properties # gradle/libs.versions.toml
- set custom refmap name - fixed console commands crashing the server (hasPermission now accepts CommandSourceStack instead of Player) - Forge wants fastutil relocated, so be it Current issues: - ClassNotFound exceptions with classes that are clearly present
- Dont relocate gson
Update feature/forge-platform to 1.20.2
…tform # Conflicts: # bootstrap/mod/src/main/java/org/geysermc/geyser/platform/mod/GeyserModBootstrap.java # bootstrap/mod/src/main/java/org/geysermc/geyser/platform/mod/ModPingPassthrough.java
- no need to include gson - cleanup nullable/nonnull annotations - add more info to geyser dumps on neoforge
…eature/forge-platform # Conflicts: # build.gradle.kts
Also add a compileOnly dependency for the mod module to get rid of spammy false warnings
onebeastchris
added
PR: Needs review
…tform # Conflicts: # bootstrap/mod/src/main/java/org/geysermc/geyser/platform/mod/GeyserModBootstrap.java # bootstrap/mod/src/main/java/org/geysermc/geyser/platform/mod/command/GeyserModCommandExecutor.java # bootstrap/mod/src/main/java/org/geysermc/geyser/platform/mod/mixin/client/IntegratedServerMixin.java
- fix duplicate nodes crashing neoforge - connector -> geyser in GeyserModCommandExecutor - create command manager early to fix issues with permission gather event
…eature/forge-platform
onebeastchris
approved these changes
Feb 16, 2024
…tform # Conflicts: # build-logic/src/main/kotlin/geyser.base-conventions.gradle.kts
Camotoy
reviewed
Feb 20, 2024
| public class GeyserModCompressionDisabler extends ChannelOutboundHandlerAdapter { | ||
|
|
||
| @Override | ||
| public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) throws Exception { |
There was a problem hiding this comment.
If we can detect a Bedrock player correctly, we could just Mixin where ClientboundLoginCompression is sent and just not send it, instead of this class. Not a stopper for a merge though.
There was a problem hiding this comment.
A mixin would be cleaner, but I think we'd then have to account for Floodgate and whatever UUID's is then used? Assuming that UUIDs is how we'd identify Bedrock players there.
Furthermore, unlike a mixin, this is less prone to mixin conflicts and version safe; so I personally would leave it at the current solution
Camotoy
approved these changes
Feb 20, 2024
…on standalone/neoforge/fabric
Kas-tle
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Geyser to run on the Forge platform.
Additionally, these changes require that we bump the Java version project-wide from 16 to 17, meaning that this should not be merged until after 1.20 is released, as we are not planning to bump the version any earlier than that.
Things left to do: