Add fetching MC versions and Console from the extensions API #4168
Conversation
|
Needs rebase or merge |
# Conflicts: # core/src/main/java/org/geysermc/geyser/GeyserImpl.java
api/src/main/java/org/geysermc/geyser/api/util/MinecraftVersion.java
Outdated
Show resolved
Hide resolved
onebeastchris
added
the
PR: Needs review
There was a problem hiding this comment.
Might be a better idea to create a new impl package or something and move this file there.
There was a problem hiding this comment.
I think I would've placed this file under org.geysermc.geyser.api.util as it's also under the util package of the api module.
There was a problem hiding this comment.
4df0458 moved it to a new impl package. Not sure how org.geysermc.geyser.api.util would work as that would end up in the api package alongside the interface it implements?
| /** | ||
| * Gets the version of Java Minecraft that is supported. | ||
| * | ||
| * @return the supported version of Java Minecraft | ||
| */ |
There was a problem hiding this comment.
If we were to follow the Google Style Guide it'd be fine to simplify this to:
Returns the version of Java Minecraft that is supported
There was a problem hiding this comment.
Not against doing that, i've mostly mirrored the style of existing method docs
onebeastchris
dismissed
Konicai’s stale review
Addressed, methods are fluent now
No description provided.