-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented ViaProxy bootstrap #4201
Implemented ViaProxy bootstrap #4201
Conversation
...ap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyBootstrap.java
Outdated
Show resolved
Hide resolved
...rap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyDumpInfo.java
Outdated
Show resolved
Hide resolved
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyLogger.java
Outdated
Show resolved
Hide resolved
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Outdated
Show resolved
Hide resolved
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Outdated
Show resolved
Hide resolved
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Outdated
Show resolved
Hide resolved
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Outdated
Show resolved
Hide resolved
Co-authored-by: chris <[email protected]>
Also please add viaproxy to be archived as build artifacts by the pr and build actions. |
I have no idea on how to do that |
See here for reference, basically that |
In pullrequest.yml as well :) |
I have some more small-ish reviews (tonight or tomorrow morning) and I'm hesitant of the current implementation anyway. Only because of what it has been forced to do under the current constraints. I would really prefer making Geyser's bootstrap system more dynamic, which I would be happy to do quite soon (as well as putting some work into this PR myself) |
On a different note, it would be nice to have some setup info on this on the Geyser wiki - while i assume the setup is similar to the plugin version, we have setup guides for all bootstraps on our wiki (https://wiki.geysermc.org/geyser/setup/). Additionally, a download link would need to be added on the downloads website; iirc @rtm516 could help with that. Regarding the wiki, feel free to reach out in the discord, we can help with that too. |
…feature/viaproxy-platform
…#start" This reverts commit 3935607.
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just some minor details.
I'm not really a big fan of setting the Floodgate auth type manually, but I'm not sure whether that can be reasonably improved
...ap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyBootstrap.java
Outdated
Show resolved
Hide resolved
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Outdated
Show resolved
Hide resolved
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Outdated
Show resolved
Hide resolved
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Outdated
Show resolved
Hide resolved
I don't really see why that's even an issue. There are plenty of other things we set for the user if certain configs are ticked because the other options would do nothing for such a setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides this one thing; LGTM
...strap/viaproxy/src/main/java/org/geysermc/geyser/platform/viaproxy/GeyserViaProxyPlugin.java
Show resolved
Hide resolved
outdated review, requested changes were implemented
Implemented a bootstrap for ViaProxy. This will replace the ViaProxyGeyserPlugin.