Show build number in startup log and version check command #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't check build number if running a dev build Show dev build warning in console
onebeastchris
added
PR: Feature
Konicai
reviewed
Dec 13, 2023
onebeastchris
added
the
PR: Needs review
Kas-tle
approved these changes
Dec 19, 2023
Camotoy
reviewed
Dec 19, 2023
Camotoy
reviewed
Dec 19, 2023
Camotoy
reviewed
Dec 19, 2023
Tim203
requested changes
Dec 31, 2023
Changed GeyserImpl.VERSION to consist of build number (e.g 420) + git info instead of geyser version (2.2.0-SNAPSHOT) + git info
Co-authored-by: Tim203 <[email protected]>
…dev to reflect build version - make isDev a variable in the GitInfo class
Camotoy
approved these changes
Jan 22, 2024
Tim203
approved these changes
Jan 22, 2024
onebeastchris
added
PR: On hold
|
Must be adapted as build number is no longer pulled directly from GH actions and instead uses the env variable |
…d-number # Conflicts: # core/build.gradle.kts
onebeastchris
changed the title
Camotoy
approved these changes
Jun 22, 2024
onebeastchris
removed
the
PR: On hold
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
…#4336) * Version check command/startup log shows build number * Add development build warning * Fix `/geyser version` command * Hack around outdated language module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
TODO's:
Would fix #1748