Revert inventory "fix" that's causing issues with quickly opening & closing inventories #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camotoy
approved these changes
Mar 27, 2024
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
…losing inventories (GeyserMC#4523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary fix for #4517 - seems like Geyser sometimes still thinks we're in an inventory when we don't actually are in one. Yikes.
Not able to look into the root cause of the issue at the moment, but this should, at the very least, undo the problematic change for now.