Fix filled cauldrons only showing as water #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onebeastchris
approved these changes
Apr 20, 2024
Kas-tle
approved these changes
Apr 20, 2024
XingLingQAQ
pushed a commit
to XingLingQAQ/Geyser
that referenced
this pull request
Sep 25, 2024
* Fix filled cauldrons only showing as water * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was originally fixed by e66014a but was reintroduced in #3083, specifically 5abc0f2Not sure if this had a purpose but just seems to be a small oversight
Edit: After looking closer, only the method name was changed, so I guess this bug has always existed
Fixes #4573