Add and rename some config options, add section notes #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclipseisoffline
approved these changes
Mar 2, 2025
core/src/main/java/org/geysermc/geyser/command/defaults/ConnectionTestCommand.java
Outdated
Show resolved
Hide resolved
…tionTestCommand.java Co-authored-by: Eclipse <[email protected]>
core/src/main/java/org/geysermc/geyser/configuration/GeyserConfig.java
Outdated
Show resolved
Hide resolved
…fig.java Co-authored-by: Eclipse <[email protected]>
Camotoy
reviewed
Mar 5, 2025
| @@ -302,6 +302,27 @@ private void startInstance() { | |||
|
|
|||
| Registries.RESOURCE_PACKS.load(); | |||
|
|
|||
| // Warnings to users who enable options that they might not need. | |||
| if (config.bedrock().useProxyProtocol()) { | |||
| logger.warning("Geyser is configured to expect proxy protocol for Bedrock connections."); | |||
There was a problem hiding this comment.
How about we make these infos? Most people using the setting are using it correctly.
core/src/main/java/org/geysermc/geyser/configuration/AdvancedConfig.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening for feedback on the new configuration option names