Download Java resourcepacks sent by the server, and load translations from them - #6578
Draft
eclipseisoffline wants to merge 12 commits into
Draft
Download Java resourcepacks sent by the server, and load translations from them#6578eclipseisoffline wants to merge 12 commits into
eclipseisoffline wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the downloading and loading of Java resourcepacks sent to Geyser sessions by the server.
The code to implement this functionality is spread over multiple classes, all residing within the
org.geysermc.geyser.pack.javapackage (or its children). TheJavaPackContentsrecord reads a Java ZIP resourcepack and holds the contents extracted from it.JavaPackManageris responsible for downloading, verifying, and caching resourcepacks across sessions.JavaPackStackis a per-session class holding the current current stack of resourcepacks, and lastly,JavaPackComposedholds the flattened-down contents of the session's stack of resourcepacks. This record is the main entrypoint for accessing Java resourcepack data.This PR is currently unfinished. Resourcepacks are correctly downloaded, cached, and its contents (translations) are loaded and composed successfully. However, these composed translations are currently not used within Geyser, as this is facing some major refactors within the
MessageTranslator/MinecraftLocalesystem.The PR also depends on #6573, and that PR will have to be merged first.
TO-DO:
JavaPackManagerneed its ownExecutorService?)