Resolve issue where disconnect messages can get hidden when another packet is being sent#906
Merged
onebeastchris merged 1 commit intoJul 25, 2025
Conversation
…acket is being sent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should resolve GeyserMC/Geyser#5375.
Was able to replicate locally, and saw that the
FIRE_EXCEPTION_ON_FAILURElistener was the one throwing the exception that occasionally led to the session being disconnected before the actual disconnection message being received:Meanwhile, Mojang's impl sets a void promise instead (unless a runnable is present!) - which, to my understanding, does not care whether the packet was actually sent (?)
This fix resolved issues with disconnection methods on my end; still opening a PR as netty is not my strong-suit 😄