Allow converting item models manually#45
Merged
eclipseisoffline merged 1 commit intoOct 13, 2025
Merged
Conversation
onebeastchris
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a field to
ModelConverterto tell it to convert models from theitemdirectory. PackConverter by default doesn't do this as bedrock's items don't have custom models that are as extensive as Java's, so there's no good place to put converted item models from Java. However, library users may still want item models converted manually.The proper way to do this is to find out where to store item models and generate item attachables along with those models as well. This will be done in a later PR.