Fix filebrowser healthcheck #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FB_PORT env variable is no longer set, so internally, within the container, port 80 is now always used. As health checks run inside the container the internal port needs to be used and not the host port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Purpose
File browser healthchecks were always failing due to using the incorrect port.
This was caused by a change where the
FB_PORTenv variable is no longer set.Approach
As the FB_PORT env variable is no longer set, internally, within the container, port 80 is now always used.
So, as health checks run inside the container, the internal port needs to be used and not the host port.
Requirements
Check all boxes as they are completed