-
Couldn't load subscription status.
- Fork 53
endpoints with next url - set the offset correctly to the pagination.offset #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3e2f5ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2194f72 to
67b16e8
Compare
67b16e8 to
f66e999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the gif paginator to correctly calculate the next offset from pagination.offset, switch to a hidden-GIFs flag for continuation logic, and use pagination.total_count to determine completion.
- Replaces the old
skipCountCheckapproach with apagination.hasMoreGifsflag. - Computes
offsetaspagination.offset + pagination.countand setsisDoneFetchingbased onpagination.total_count. - Adds a changeset entry documenting the hidden-GIFs workaround.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/fetch-api/src/paginator.ts | Revise pagination offset logic, hidden GIFs flag usage, and fetch completion check |
| .changeset/rotten-cups-hear.md | Document patch for hidden GIFs workaround |
Comments suppressed due to low confidence (2)
packages/fetch-api/src/paginator.ts:43
- [nitpick] The variable name
gis ambiguous; consider renaming it to something more descriptive likepaginatedGifsorcurrentGifs.
const g = [...gifs]
packages/fetch-api/src/paginator.ts:27
- [nitpick] The comment here could be more precise—e.g.
Set offset to pagination.offset + pagination.count for the next fetch call—to better explain the logic.
// on the next request, this will be the offset
No description provided.