Add pre-commit hook #4 #8
Conversation
| @@ -21,7 +21,9 @@ | |||
| "develop": "gatsby develop", | |||
| "format": "prettier --write 'src/**/*.js'", | |||
| "eslint": "node_modules/eslint-watch/bin/esw -w --fix", | |||
| "test": "echo \"Error: no test specified\" && exit 1" | |||
| "lint": "node_modules/.bin/eslint .", | |||
There was a problem hiding this comment.
Why you have added it again.
eslint is already there right?
There was a problem hiding this comment.
the earlier eslint command runs in watch mode, can I change it to the new command?
There was a problem hiding this comment.
Do you know what pre-hook commit do ?
|
@rahulrana95 should all the words in the commit message be capitalized (Add Precommit Hook) or only the first word of the message(Add precommit hook) ? |
|
@adarshlilha Make first character of all letters capital |
|
@adarshlilha Any update on this PR |
|
sorry for the delay. I tried using husky to run a custom script to verify all words start with a capital letter but couldn't get this working. Will need help from someone to look into this. |
|
Google about pre-hook and how it works. |
|
@adarshlilha Are you planning to work on this issue? @rahulrana95 Please Provide complete comment with what needs to updated in the PR to merge. Need to close this soon. |
Added husky and modified package.json scripts to run linter before git commit