fix(sarif): Use level variable for detector status handling Fix for … #1154
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue GitGuardian#1122: Implement support for setting SARIF report level based on detector enabled/disabled status. This commit adds a level variable that can be computed based on whether the detector is enabled or disabled from the platform configuration. Currently defaults to "error" for all detectors, but provides the framework for checking detector status and setting level to "note" for disabled detectors as proposed in issue GitGuardian#1122. Changes: - Added level variable computation in _create_sarif_result_dict() - Updated SARIF result to use dynamic level variable instead of hardcoded "error" - Added TODO comment for implementing platform detector status check Added logic to determine level based on detector status and included a TODO for future enhancements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…issue #1122: Implement support for setting SARIF report level based on detector enabled/disabled status. This commit adds a level variable that can be computed based on whether the detector is enabled or disabled from the platform configuration. Currently defaults to "error" for all detectors, but provides the framework for checking detector status and setting level to "note" for disabled detectors as proposed in issue #1122. Changes: - Added level variable computation in _create_sarif_result_dict() - Updated SARIF result to use dynamic level variable instead of hardcoded "error" - Added TODO comment for implementing platform detector status check
Added logic to determine level based on detector status and included a TODO for future enhancements.
Context
What has been done
Validation
PR check list
skip-changeloglabel has been added to the PR.