Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(models): Add is_diff to ScanResult and diff_kind to PolicyBreak #122

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Walz
Copy link
Collaborator

@Walz Walz commented Nov 13, 2024

Add two new fields to the result of scans:

  • Add field is_diff to ScanResult
  • Add field diff_kind to PolicyBreak

@Walz Walz force-pushed the samuel/spi-526-add-fields-is-diff-and-diff-kind branch from d72e5ad to 1e9de0e Compare November 13, 2024 08:53
@Walz Walz requested a review from agateau-gg November 13, 2024 09:51
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks, looks good overall.

@Walz Walz force-pushed the samuel/spi-526-add-fields-is-diff-and-diff-kind branch from 1e9de0e to efa3f11 Compare November 13, 2024 10:52
@Walz Walz requested a review from agateau-gg November 13, 2024 10:59
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@agateau-gg agateau-gg merged commit 7888a30 into master Nov 13, 2024
19 checks passed
@agateau-gg agateau-gg deleted the samuel/spi-526-add-fields-is-diff-and-diff-kind branch November 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants