Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-release renames #128

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Pre-release renames #128

merged 2 commits into from
Nov 25, 2024

Conversation

agateau-gg
Copy link
Collaborator

While reviewing the ggshield PR to check for tokens I realized two naming inconsistencies were merged here. This PR fixes them before we release:

  • TokenScopes -> TokenScope: because enum names should be singular
  • ApiToken* -> APIToken*: because PEP 8 says so. Also, this is more consistent with other classes of the package (JWTService, JWTResponse...)

@agateau-gg agateau-gg requested a review from a team as a code owner November 25, 2024 09:19
@agateau-gg agateau-gg added the skip-changelog No changelog check in the CI label Nov 25, 2024
@agateau-gg agateau-gg mentioned this pull request Nov 25, 2024
Merged
2 tasks
@agateau-gg agateau-gg merged commit bf46665 into master Nov 25, 2024
19 of 20 checks passed
@agateau-gg agateau-gg deleted the agateau/renames branch November 25, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salome-voltz salome-voltz salome-voltz approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog check in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agateau-gg @salome-voltz