Fix tests to pass without cassettes #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove VCR decorator: the code uses a VCR `with` block. - Do not wrap the wall test in the VCR `with` block: only wrap the call to `client.multi_content_scan()` - Early return if `expected` is None - Load `expected` into `example_dict` only once
`.env` policy breaks are no longer reported by the API. Remove the code testing this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 5 5
Lines 1196 1196
=======================================
Hits 1145 1145
Misses 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our API no longer reports "Filenames" policy breaks. As a result the
test_content_scan()andtest_multi_content_scan()tests were failing.This PR updates the tests to match the new API behavior.